Prerequisites

• I have added steps to test this contribution in the description below

Addresses: #19010

Description

The linked issue describes two concerns, only only one of which I could replicate, and which is addressed in this PR.

I've used the following setup:

With these domains:

• Site A Home - localhost:44339
• Site B Home - localhost:44340

I've then configured Umbraco to launch with these URLs (in Program.cs):

WebApplicationBuilder builder = WebApplication.CreateBuilder(args);

builder.WebHost.UseUrls("https://localhost:44339", "https://localhost:44340", "https://localhost:44341");

Navigating to the following pages gives these results:

• https://localhost:44339/sample-page/ - renders page
• https://localhost:44339/sample-page-2/ - renders page
• https://localhost:44340/sample-page/ - renders page
• https://localhost:44340/sample-page-2/ - returns 404
• https://localhost:44341/sample-page/ - renders page (from Site A).

The issue is reporting two things:

1. That when requesting a page under a domain, where the domain exists but the page doesn't, and it does exist under the root node - it'll return that. However I can't replicate this.
2. That when requesting a page under a domain, where the domain doesn't exist, and it does exist under the root node - it'll return that. This one I can see and as, per the linked issue, it likely isn't what you want.

So this PR addresses the second issue. I considered it would be breaking to change this behaviour, and are situations where the current behaviour is desired (not least, when no domains are configured), so have introduced a new configuration option:

  "WebRouting": {
    "UseStrictDomainMatching": true
  },

This defaults to false, which keeps the current behaviour. When set to true, the page won't be routed if a domain is not found and attached to the request provided to the content finder.

With that we get the following results:

• https://localhost:44339/sample-page/ - renders page
• https://localhost:44339/sample-page-2/ - renders page
• https://localhost:44340/sample-page/ - renders page
• https://localhost:44340/sample-page-2/ - returns 404
• https://localhost:44341/sample-page/ - returns 404

Testing

Review and verify what's described above.